Abstract
An examination is made of the one-electron theory of x-ray transitions in metals. A question is raised whether the one-electron theory should be calculated using the potential of the central atomic core which does, or does, not, include the screened core hole. It is suggested that one should use the potential of the final state, which has the core hole in absorption and not in emission. This suggestion agrees with emission data, as well as Mahan-Nozières-De Dominicis theory which is solved numerically for a square-well potential.